| Summary: | [iOS] Occasional crash under -[UIView _setViewDelegate:] when presenting date and time pickers | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||
| Component: | Forms | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aestes, cdumez, darin, dino, hi, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Wenson Hsieh
2020-07-08 20:58:28 PDT
Created attachment 403843 [details]
Patch
Comment on attachment 403843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403843&action=review > Source/WebKit/ChangeLog:31 > + Make it possible to test date and time picker presentation and dismissal by calling into the private testing- These testing hooks seem a little complicated in their own right. Wish there was a more straightforward pattern. Comment on attachment 403843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403843&action=review >> Source/WebKit/ChangeLog:31 >> + Make it possible to test date and time picker presentation and dismissal by calling into the private testing- > > These testing hooks seem a little complicated in their own right. Wish there was a more straightforward pattern. Yes! I think that ideally, we’d want to limit this kind of test-specific logic to the actual testing harness (WebKitTestRunner) as much as possible, but it’s tricky here because WKTR can’t really get at the context menu interaction or listen for its delegate methods. Maybe a simpler, polling-based approach would be more maintainable in the long run... Committed r264170: <https://trac.webkit.org/changeset/264170> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403843 [details]. |