Bug 21411

Summary: ResourceHandleInternal.h uses NS class without C++ declaration
Product: WebKit Reporter: Jeremy Moskovich <playmobil>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Add forward declaration
mitz: review+
Add email address to changelog. mitz: review+

Jeremy Moskovich
Reported 2008-10-06 14:13:04 PDT
ResourceHandleInternal.h is included from ResourceHandle.cpp so it should be a valid C++ header. However, contains a NSURLAuthenticationChallenge without a C++ compatible forward declaration.
Attachments
Add forward declaration (1.21 KB, patch)
2008-10-06 14:17 PDT, Jeremy Moskovich 		mitz: review+
DetailsFormatted DiffDiff
Add email address to changelog. (1.19 KB, patch)
2008-10-06 14:26 PDT, Jeremy Moskovich 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeremy Moskovich
Comment 1 2008-10-06 14:17:03 PDT
Created attachment 24122 [details] Add forward declaration
mitz
Comment 2 2008-10-06 14:24:03 PDT
Comment on attachment 24122 [details] Add forward declaration r=me
mitz
Comment 3 2008-10-06 14:24:45 PDT
(In reply to comment #2) > (From update of attachment 24122 [details] [edit]) > r=me But please fix +2008-10-06 Jeremy Moskovich <set EMAIL_ADDRESS environment variable>
Jeremy Moskovich
Comment 4 2008-10-06 14:26:49 PDT
Created attachment 24123 [details] Add email address to changelog.
mitz
Comment 5 2008-10-06 14:28:22 PDT
Comment on attachment 24123 [details] Add email address to changelog. r=me again
Eric Seidel (no email)
Comment 6 2008-10-06 18:05:46 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/network/ResourceHandleInternal.h Committed r37357
Note You need to log in before you can comment on or make changes to this bug.