Bug 214101 – [Windows] Fix errors from calls to uname when not available

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Stephan Szabo]

uname is not something guaranteed available for Windows. Recent updates for calling uname have appeared to cause errors or warnings for commands (build-webkit, check-webkit-style, etc) when used from non-posix shells (like powershell or cmd).

[Stephan Szabo]

Created attachment 403812 [details]
Patch

[Darin Adler]

Comment on attachment 403812 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403812&action=review

Seems OK

> Tools/Scripts/webkitdirs.pm:365
> -        $output = `uname -m`;
> +        if (!isWindows()) {
> +            $output = `uname -m`;
> +        }

In Perl we would idiomatically write this:

    $output = `uname -m` unless isWindows();

> Tools/Scripts/webkitdirs.pm:369
> +    chomp $output if (defined $output);

No need for those parentheses.

[Stephan Szabo]

Created attachment 403818 [details]
Patch

[EWS]

Committed r264142: <https://trac.webkit.org/changeset/264142>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403818 [details].

[Radar WebKit Bug Importer]

<rdar://problem/65248364>