RESOLVED FIXED 214101
[Windows] Fix errors from calls to uname when not available 
https://bugs.webkit.org/show_bug.cgi?id=214101
Summary [Windows] Fix errors from calls to uname when not available
Stephan Szabo
Reported 2020-07-08 15:20:40 PDT
uname is not something guaranteed available for Windows. Recent updates for calling uname have appeared to cause errors or warnings for commands (build-webkit, check-webkit-style, etc) when used from non-posix shells (like powershell or cmd).
Attachments
Patch (2.54 KB, patch)
2020-07-08 15:49 PDT, Stephan Szabo 		darin: review+
DetailsFormatted DiffDiff
Patch (2.51 KB, patch)
2020-07-08 16:35 PDT, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2020-07-08 15:49:05 PDT
Created attachment 403812 [details] Patch
Darin Adler
Comment 2 2020-07-08 16:25:39 PDT
Comment on attachment 403812 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403812&action=review Seems OK > Tools/Scripts/webkitdirs.pm:365 > - $output = `uname -m`; > + if (!isWindows()) { > + $output = `uname -m`; > + } In Perl we would idiomatically write this: $output = `uname -m` unless isWindows(); > Tools/Scripts/webkitdirs.pm:369 > + chomp $output if (defined $output); No need for those parentheses.
Stephan Szabo
Comment 3 2020-07-08 16:35:50 PDT
Created attachment 403818 [details] Patch
EWS
Comment 4 2020-07-08 17:14:46 PDT
Committed r264142: <https://trac.webkit.org/changeset/264142> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403818 [details].
Radar WebKit Bug Importer
Comment 5 2020-07-08 17:15:14 PDT
<rdar://problem/65248364>
Note You need to log in before you can comment on or make changes to this bug.