Bug 214096

Summary:

Make a logging channel for ScrollSnap and improve its logging

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, ews-watchlist, fred.wang, graouts, jamesr, luiz, simon.fraser, tonikitoo, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	wenson_hsieh: review+

Description Simon Fraser (smfr) 2020-07-08 13:21:32 PDT

Make a logging channel for ScrollSnap and improve its logging

Comment 1 Simon Fraser (smfr) 2020-07-08 13:22:41 PDT

Created attachment 403805 [details]
Patch

Comment 2 Wenson Hsieh 2020-07-08 13:24:25 PDT

Comment on attachment 403805 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403805&action=review

> Source/WebCore/platform/cocoa/ScrollSnapAnimatorState.mm:123
> +        ts.dumpProperty("snap offsets ranges x", state.snapOffsetRangesForAxis(ScrollEventAxis::Vertical));

This should say “y"

Comment 3 Simon Fraser (smfr) 2020-07-08 14:41:07 PDT

https://trac.webkit.org/changeset/264134/webkit

Comment 4 Radar WebKit Bug Importer 2020-07-08 14:42:17 PDT

<rdar://problem/65241839>