Bug 214089

Summary: ErrorInstance::finishCreation() puts "message" twice, with different attributes
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: JavaScriptCoreAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Enhancement CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 142933    
Attachments:
Description Flags
Patch none

Alexey Shvayka
Reported 2020-07-08 10:58:29 PDT
Put "message" to ErrorInstance with consistent attributes
Attachments
Patch (8.05 KB, patch)
2020-07-08 16:51 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2020-07-08 16:51:37 PDT
Created attachment 403823 [details] Patch
Alexey Shvayka
Comment 2 2020-07-08 16:52:16 PDT
(In reply to Alexey Shvayka from comment #1) > Created attachment 403823 [details] > Patch Warmed-up runs, --outer 50: r263795 patch error-source-appender 103.3675+-1.5723 ^ 97.8376+-1.3031 ^ definitely 1.0565x faster <geometric> 103.3675+-1.5723 ^ 97.8376+-1.3031 ^ definitely 1.0565x faster
Yusuke Suzuki
Comment 3 2020-07-08 17:06:31 PDT
Comment on attachment 403823 [details] Patch r=me
EWS
Comment 4 2020-07-09 01:23:40 PDT
Committed r264160: <https://trac.webkit.org/changeset/264160> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403823 [details].
Radar WebKit Bug Importer
Comment 5 2020-07-09 01:24:18 PDT
<rdar://problem/65262018>
Note You need to log in before you can comment on or make changes to this bug.