Bug 214089 - ErrorInstance::finishCreation() puts "message" twice, with different attributes
Summary: ErrorInstance::finishCreation() puts "message" twice, with different attributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Enhancement
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks: 142933
  Show dependency tree / graph
 
Reported: 2020-07-08 10:58 PDT by Alexey Shvayka
Modified: 2020-07-09 01:24 PDT (History)
8 users (show)

See Also:

Attachments
Patch (8.05 KB, patch)
2020-07-08 16:51 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2020-07-08 10:58:29 PDT 
Put "message" to ErrorInstance with consistent attributes
Comment 1 Alexey Shvayka 2020-07-08 16:51:37 PDT 
Created attachment 403823 [details]
Patch
Comment 2 Alexey Shvayka 2020-07-08 16:52:16 PDT 
(In reply to Alexey Shvayka from comment #1)
> Created attachment 403823 [details]
> Patch

Warmed-up runs, --outer 50:

                                r263795                    patch

error-source-appender      103.3675+-1.5723     ^     97.8376+-1.3031        ^ definitely 1.0565x faster

<geometric>                103.3675+-1.5723     ^     97.8376+-1.3031        ^ definitely 1.0565x faster
Comment 3 Yusuke Suzuki 2020-07-08 17:06:31 PDT 
Comment on attachment 403823 [details]
Patch

r=me
Comment 4 EWS 2020-07-09 01:23:40 PDT 
Committed r264160: <https://trac.webkit.org/changeset/264160>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403823 [details].
Comment 5 Radar WebKit Bug Importer 2020-07-09 01:24:18 PDT 
<rdar://problem/65262018>