Bug 214059

Summary: [Cocoa] Fix adjust-angle-include-paths.sh error seen building ANGLE library
Product: WebKit Reporter: Darin Adler <darin>
Component: Tools / TestsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, dino, ews-watchlist, graouts, kondapallykalyan, krollin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Darin Adler
Reported 2020-07-07 14:26:59 PDT
Fix adjust-angle-include-paths.sh error seen building ANGLE library
Attachments
Patch (13.37 KB, patch)
2020-07-07 14:27 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2020-07-07 14:27:46 PDT
Created attachment 403726 [details] Patch
EWS Watchlist
Comment 2 2020-07-07 15:13:54 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Alexey Proskuryakov
Comment 3 2020-07-07 18:22:43 PDT
Comment on attachment 403726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403726&action=review rs=me if Dean says so! > Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj:-4276 > - outputFileListPaths = ( > - ); > - outputPaths = ( > - ); Hmm, do we have the same for dynamic library target? No dependencies - bad for XCBuild.
Keith Rollin
Comment 4 2020-07-07 18:46:24 PDT
XCBuild doesn't use this Run Script build phase, so it's OK if there are no dependencies. Instead, the copy-and-mutate-header-files is done in the Copy Headers build phase.
EWS
Comment 5 2020-07-08 10:56:38 PDT
Committed r264116: <https://trac.webkit.org/changeset/264116> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403726 [details].
Radar WebKit Bug Importer
Comment 6 2020-07-08 10:57:36 PDT
<rdar://problem/65231817>
Note You need to log in before you can comment on or make changes to this bug.