Bug 214056

Summary: Use sendWithAsyncReply instead of EditingRangeCallback
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2020-07-07 14:10:45 PDT
Use sendWithAsyncReply instead of EditingRangeCallback
Attachments
Patch (13.48 KB, patch)
2020-07-07 14:11 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (12.88 KB, patch)
2020-07-07 14:49 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-07-07 14:11:04 PDT
Created attachment 403722 [details] Patch
Chris Dumez
Comment 2 2020-07-07 14:23:17 PDT
Comment on attachment 403722 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403722&action=review > Source/WebKit/UIProcess/Cocoa/WKReloadFrameErrorRecoveryAttempter.mm:53 > + WTFLogAlways("ALEX WKReloadFrameErrorRecoveryAttempter %s", urlString.utf8().data()); Oops
Chris Dumez
Comment 3 2020-07-07 14:23:35 PDT
Comment on attachment 403722 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403722&action=review > Source/WebKit/ChangeLog:8 > + No new tests (OOPS!). Oops again
Alex Christensen
Comment 4 2020-07-07 14:49:48 PDT
Created attachment 403729 [details] Patch
Chris Dumez
Comment 5 2020-07-07 15:29:07 PDT
Comment on attachment 403729 [details] Patch r=me if bots are happy
EWS
Comment 6 2020-07-07 16:30:54 PDT
Committed r264047: <https://trac.webkit.org/changeset/264047> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403729 [details].
Radar WebKit Bug Importer
Comment 7 2020-07-07 16:31:23 PDT
<rdar://problem/65198975>
Note You need to log in before you can comment on or make changes to this bug.