Bug 214056 - Use sendWithAsyncReply instead of EditingRangeCallback
Summary: Use sendWithAsyncReply instead of EditingRangeCallback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-07 14:10 PDT by Alex Christensen
Modified: 2020-07-07 16:31 PDT (History)
2 users (show)

See Also:

Attachments
Patch (13.48 KB, patch)
2020-07-07 14:11 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (12.88 KB, patch)
2020-07-07 14:49 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-07-07 14:10:45 PDT 
Use sendWithAsyncReply instead of EditingRangeCallback
Comment 1 Alex Christensen 2020-07-07 14:11:04 PDT 
Created attachment 403722 [details]
Patch
Comment 2 Chris Dumez 2020-07-07 14:23:17 PDT 
Comment on attachment 403722 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403722&action=review

> Source/WebKit/UIProcess/Cocoa/WKReloadFrameErrorRecoveryAttempter.mm:53
> +    WTFLogAlways("ALEX WKReloadFrameErrorRecoveryAttempter %s", urlString.utf8().data());

Oops
Comment 3 Chris Dumez 2020-07-07 14:23:35 PDT 
Comment on attachment 403722 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403722&action=review

> Source/WebKit/ChangeLog:8
> +        No new tests (OOPS!).

Oops again
Comment 4 Alex Christensen 2020-07-07 14:49:48 PDT 
Created attachment 403729 [details]
Patch
Comment 5 Chris Dumez 2020-07-07 15:29:07 PDT 
Comment on attachment 403729 [details]
Patch

r=me if bots are happy
Comment 6 EWS 2020-07-07 16:30:54 PDT 
Committed r264047: <https://trac.webkit.org/changeset/264047>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403729 [details].
Comment 7 Radar WebKit Bug Importer 2020-07-07 16:31:23 PDT 
<rdar://problem/65198975>