Bug 214030

Summary: Add WebCoreNSURLSession SPI to send HTTP/2 ping
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, eric.carlson, ews-watchlist, glenn, japhet, jer.noble, philipj, sam, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 214747    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2020-07-06 20:56:39 PDT
Add WebCoreNSURLSession SPI to send HTTP/2 ping
Attachments
Patch (50.94 KB, patch)
2020-07-06 21:04 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (49.88 KB, patch)
2020-07-06 21:09 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (50.33 KB, patch)
2020-07-06 21:45 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (51.30 KB, patch)
2020-07-07 09:00 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-07-06 21:04:43 PDT
Created attachment 403661 [details] Patch
Alex Christensen
Comment 2 2020-07-06 21:04:45 PDT
<rdar://problem/64495827>
Alex Christensen
Comment 3 2020-07-06 21:09:29 PDT
Created attachment 403662 [details] Patch
Alex Christensen
Comment 4 2020-07-06 21:45:18 PDT
Created attachment 403664 [details] Patch
Sam Weinig
Comment 5 2020-07-07 07:46:14 PDT
Comment on attachment 403664 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403664&action=review > Source/WebCore/loader/FrameLoaderClient.h:361 > + virtual void sendH2Ping(const URL&, CompletionHandler<void(Expected<Seconds, ResourceError>&&)>&&); This should be pure-virtual. By moving the ASSERT to WebKitLegacy, it will make it clear if it ever gets called that it is WebKitLegacy that has not implemented it. > Source/WebCore/platform/graphics/PlatformMediaResourceLoader.h:70 > + virtual void sendH2Ping(const URL&, CompletionHandler<void(Expected<Seconds, ResourceError>&&)>&&); Same here. This should be pure-virtual.
Alex Christensen
Comment 6 2020-07-07 09:00:19 PDT
Created attachment 403695 [details] Patch
EWS
Comment 7 2020-07-07 10:05:03 PDT
Committed r264021: <https://trac.webkit.org/changeset/264021> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403695 [details].
Note You need to log in before you can comment on or make changes to this bug.