Bug 214011

Summary:

[iOS] WAKWindow should override -resignFirstResponder and clear state

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Daniel Bates

Reported 2020-07-06 16:02:14 PDT

WAKWindow maintains state of what the first responder and next responder are. I need way to clear this state when removing a UIWebView from its superview.

Attachments
Patch (1.83 KB, patch) 2020-07-06 16:21 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-07-06 16:02:31 PDT

<rdar://problem/65152410>

Daniel Bates

Comment 2 2020-07-06 16:05:18 PDT

Note that only -[WAKWindow close] ever nils out this state. -makeFirstResponder early returns if passed nil. In AppKit, -makeFirstResponder:nil would make the window first responder, but -firstResponder is in term of WAKView and there doesn't seem to be an existing concept of a "first responder" window.

Daniel Bates

Comment 3 2020-07-06 16:21:57 PDT

Created attachment 403631 [details] Patch

Daniel Bates

Comment 4 2020-07-06 16:27:29 PDT

Thanks Tim!

Daniel Bates

Comment 5 2020-07-06 16:28:00 PDT

Comment on attachment 403631 [details] Patch Clearing flags on attachment: 403631 Committed r263995: <https://trac.webkit.org/changeset/263995>

Daniel Bates

Comment 6 2020-07-06 16:28:02 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.