Bug 213990 – [WPE][GTK] CMake warnings

• Component: CMake
• Status: RESOLVED FIXED

[Philippe Normand]

--  demux (required): /usr/lib/x86_64-linux-gnu/libwebpdemux.so
CMake Warning (dev) at /usr/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:272 (message):
  The package name passed to `find_package_handle_standard_args` (ATK_BRIDGE)
  does not match the name of the calling package (ATKBridge).  This can lead
  to problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  Source/cmake/FindATKBridge.cmake:47 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  Source/cmake/WebKitFindPackage.cmake:104 (_find_package)
  Source/cmake/OptionsWPE.cmake:132 (find_package)
  Source/cmake/WebKitCommon.cmake:58 (include)
  CMakeLists.txt:173 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning at Source/cmake/FindWOFF2.cmake:76 (message):
  Cannot determine WOFF2 version without pkg-config
Call Stack (most recent call first):
  Source/cmake/WebKitFindPackage.cmake:104 (_find_package)
  Source/cmake/OptionsWPE.cmake:146 (find_package)
  Source/cmake/WebKitCommon.cmake:58 (include)
  CMakeLists.txt:173 (include)

[Adrian Perez]

(In reply to Philippe Normand from comment #0)
> --  demux (required): /usr/lib/x86_64-linux-gnu/libwebpdemux.so
> CMake Warning (dev) at
> /usr/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:272
> (message):
>   The package name passed to `find_package_handle_standard_args` (ATK_BRIDGE)
>   does not match the name of the calling package (ATKBridge).  This can lead
>   to problems in calling code that expects `find_package` result variables
>   (e.g., `_FOUND`) to follow a certain pattern.
> Call Stack (most recent call first):
>   Source/cmake/FindATKBridge.cmake:47 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
>   Source/cmake/WebKitFindPackage.cmake:104 (_find_package)
>   Source/cmake/OptionsWPE.cmake:132 (find_package)
>   Source/cmake/WebKitCommon.cmake:58 (include)
>   CMakeLists.txt:173 (include)
> This warning is for project developers.  Use -Wno-dev to suppress it.

We have a few more with CMake 3.17 (or at least I started to notice
more warnings recently which I think it was after CMake was updated
to 3.17.3 in Arch Linux).

It would be good to take advantage of the situation to also convert
the offending find-modules to use imported targets, while at it :-)

> CMake Warning at Source/cmake/FindWOFF2.cmake:76 (message):
>   Cannot determine WOFF2 version without pkg-config
> Call Stack (most recent call first):
>   Source/cmake/WebKitFindPackage.cmake:104 (_find_package)
>   Source/cmake/OptionsWPE.cmake:146 (find_package)
>   Source/cmake/WebKitCommon.cmake:58 (include)
>   CMakeLists.txt:173 (include)

This second warning has been already fixed in bug #214012 / r264012

[Adrian Perez]

(In reply to Philippe Normand from comment #0)
> --  demux (required): /usr/lib/x86_64-linux-gnu/libwebpdemux.so
> CMake Warning (dev) at
> /usr/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:272
> (message):
>   The package name passed to `find_package_handle_standard_args` (ATK_BRIDGE)
>   does not match the name of the calling package (ATKBridge).  This can lead
>   to problems in calling code that expects `find_package` result variables
>   (e.g., `_FOUND`) to follow a certain pattern.
> Call Stack (most recent call first):
>   Source/cmake/FindATKBridge.cmake:47 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
>   Source/cmake/WebKitFindPackage.cmake:104 (_find_package)
>   Source/cmake/OptionsWPE.cmake:132 (find_package)
>   Source/cmake/WebKitCommon.cmake:58 (include)
>   CMakeLists.txt:173 (include)
> This warning is for project developers.  Use -Wno-dev to suppress it.

This one was fixed in bug #216773 ­— the fix landed in r267399

[Adrian Perez]

Closing, CMake warnings are no more in “trunk” 😊️