Bug 213971

Summary: Web Inspector: Fix python3 build warnings
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: Web InspectorAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, sam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Philippe Normand
Reported 2020-07-05 05:27:00 PDT
I get a bunch of those: Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator.py:70: SyntaxWarning: "is" with a literal. Did you mean "=="? elif _type.raw_name() is 'number':
Attachments
Patch (13.74 KB, patch)
2020-07-05 06:27 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2020-07-05 06:27:15 PDT
Created attachment 403556 [details] Patch
EWS Watchlist
Comment 2 2020-07-05 06:28:05 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
EWS
Comment 3 2020-07-05 07:23:07 PDT
Committed r263951: <https://trac.webkit.org/changeset/263951> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403556 [details].
Radar WebKit Bug Importer
Comment 4 2020-07-05 07:24:15 PDT
<rdar://problem/65107011>
Note You need to log in before you can comment on or make changes to this bug.