Bug 213968

Summary: [Flatpak SDK] Misc updates
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: Tools / TestsAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, svillar, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Philippe Normand
Reported 2020-07-05 02:51:00 PDT
I have a few changes piling up...
Attachments
Patch (5.98 KB, patch)
2020-07-05 02:53 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (5.95 KB, patch)
2020-07-06 01:11 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2020-07-05 02:53:20 PDT
Created attachment 403550 [details] Patch
Sergio Villar Senin
Comment 2 2020-07-06 00:53:54 PDT
Comment on attachment 403550 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403550&action=review > Tools/flatpak/flatpakutils.py:1034 > + runner_args.append("--%s" % arg[10:]) Perhaps we need some clarification about this magic number
Philippe Normand
Comment 3 2020-07-06 01:11:44 PDT
Created attachment 403579 [details] Patch
Philippe Normand
Comment 4 2020-07-06 01:12:55 PDT
Comment on attachment 403579 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403579&action=review > Tools/flatpak/flatpakutils.py:1035 > + opt_prefix = "--flatpak-" > + for arg in args: > + if arg.startswith(opt_prefix): > + runner_args.append("--%s" % arg[len(opt_prefix):]) Thanks, I think it looks better now.
EWS
Comment 5 2020-07-06 01:35:36 PDT
Committed r263963: <https://trac.webkit.org/changeset/263963> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403579 [details].
Radar WebKit Bug Importer
Comment 6 2020-07-06 01:36:15 PDT
<rdar://problem/65123062>
Note You need to log in before you can comment on or make changes to this bug.