Bug 21396

Summary: Remove the OptionalCalleeActivation call frame slot
Product: WebKit Reporter: Cameron Zwarich (cpst) <zwarich>
Component: JavaScriptCoreAssignee: Cameron Zwarich (cpst) <zwarich>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 20812    
Attachments:
Description Flags
Proposed patch
none
Revised proposed patch oliver: review+

Description Cameron Zwarich (cpst) 2008-10-05 22:45:30 PDT
After bug 21364 is resolved, we can do this.
Comment 1 Cameron Zwarich (cpst) 2008-10-06 17:06:14 PDT
Created attachment 24130 [details]
Proposed patch
Comment 2 Cameron Zwarich (cpst) 2008-10-06 20:15:22 PDT
Created attachment 24137 [details]
Revised proposed patch

This fixes the crash. It was a problem with the ScopeChain dereffing in unwindCallFrame().
Comment 3 Oliver Hunt 2008-10-06 20:42:33 PDT
Comment on attachment 24137 [details]
Revised proposed patch

r=me, but i'd like a bug to cover the absence of documentation on op_tear_off_activation and op_enter_with_activation
Comment 4 Cameron Zwarich (cpst) 2008-10-06 20:54:06 PDT
Landed in r37366.