Summary: | [SOUP] Add support for HTTPCookieAcceptPolicy::OnlyFromMainDocumentDomain | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | agomez, berto, bugs-noreply, clopez, ews-watchlist, gustavo, ltilve, mcatanzaro, pnormand | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=213502 https://bugs.webkit.org/show_bug.cgi?id=193458 |
||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 214077 | ||||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2020-07-04 05:18:55 PDT
Created attachment 403520 [details] WIP This is wip, it requires new libsoup API, and a new release to add version checks to use the new policy. See https://gitlab.gnome.org/GNOME/libsoup/-/merge_requests/127 After this, I agree we should rename the policies to avoid confusion between "Only" and "Exclusively" as proposed in bug #193458. Comment on attachment 403520 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=403520&action=review Looks good. > Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:294 > - if (m_thirdPartyCookieBlockingMode == ThirdPartyCookieBlockingMode::All && m_cookieAcceptPolicy == HTTPCookieAcceptPolicy::OnlyFromMainDocumentDomain) > + if (m_thirdPartyCookieBlockingMode == ThirdPartyCookieBlockingMode::All && m_cookieAcceptPolicy == HTTPCookieAcceptPolicy::ExclusivelyFromMainDocumentDomain) I think we need a comment to explain why we are rejecting changes to ExclusivelyFromMainDocumentDomain but not to OnlyFromMainDocumentDomain: OnlyFromMainDocumentDomain is the default behavior when running layout tests, we have a couple tests that depend on it, and OnlyFromMainDocumentDomain cannot be set by public API users so they'll never notice. Created attachment 403687 [details]
WIP
Updated and also includes the test expectations.
Created attachment 403772 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 403772 [details]
Patch
I have built this, along with SDK, http tests pass in GTK/Release.
(In reply to Philippe Normand from comment #7) > Comment on attachment 403772 [details] > Patch > > I have built this, along with SDK, http tests pass in GTK/Release. Does this mean I can land the patch and the bots will have the new libsoup already? Committed r264156: <https://trac.webkit.org/changeset/264156> SDK r264156 is deployed... |