Bug 213912

Summary: Change the names of MIMETypeRegistry methods to comply with webkit naming style
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: New BugsAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, calvaris, cdumez, cgarcia, changseok, darin, eric.carlson, esprehn+autocc, ews-watchlist, fujii.hironori, galpeter, glenn, gustavo, gyuyoung.kim, japhet, jer.noble, menard, mifenton, philipj, pnormand, sergio, simon.fraser, thorton, vjaquez, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=213826
Attachments:
Description Flags
Patch
none
Patch none

Said Abou-Hallawa
Reported 2020-07-02 17:52:38 PDT
Change the name of the following methods: MIMETypeRegistry::getMIMETypeForExtension MIMETypeRegistry::getExtensionsForMIMEType MIMETypeRegistry::getPreferredExtensionForMIMEType MIMETypeRegistry::getMediaMIMETypeForExtension MIMETypeRegistry::getMIMETypeForPath MIMETypeRegistry::getNormalizedMIMEType To be: MIMETypeRegistry::mimeTypeForExtension MIMETypeRegistry::extensionsForMIMEType MIMETypeRegistry::preferredExtensionForMIMEType MIMETypeRegistry::mediaMIMETypeForExtension MIMETypeRegistry::mimeTypeForPath MIMETypeRegistry::normalizedMIMEType
Attachments
Patch (29.54 KB, patch)
2020-07-02 18:00 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (33.07 KB, patch)
2020-07-02 18:10 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2020-07-02 18:00:47 PDT
Created attachment 403424 [details] Patch
Said Abou-Hallawa
Comment 2 2020-07-02 18:10:39 PDT
Created attachment 403427 [details] Patch
EWS Watchlist
Comment 3 2020-07-02 18:11:44 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
EWS
Comment 4 2020-07-03 02:35:52 PDT
Committed r263890: <https://trac.webkit.org/changeset/263890> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403427 [details].
Radar WebKit Bug Importer
Comment 5 2020-07-03 02:36:19 PDT
<rdar://problem/65069686>
Fujii Hironori
Comment 6 2020-07-03 17:42:27 PDT
Committed r263923: <https://trac.webkit.org/changeset/263923>
Note You need to log in before you can comment on or make changes to this bug.