Summary: | [Flatpak SDK][WPE] Launching the remote inspector kills MB | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||
Component: | Tools / Tests | Assignee: | Philippe Normand <pnormand> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aperez, cgarcia, ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, pnormand, saam, tzagallo, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Sergio Villar Senin
2020-07-02 13:09:07 PDT
Oh yeah I saw a similar error today. But I think in GTK it works. Need to debug... :) This fails in Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorUtils.cpp where I suspect we might need to check an env-var additionally to the build-time hardcoded lib path. It works fine in GTK because the inspector commands are loaded from a GResource embedded in the lib. Created attachment 403766 [details]
Patch
Comment on attachment 403766 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403766&action=review > Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorUtils.cpp:49 > + const char* path = g_getenv("WEBKIT_INJECTED_BUNDLE_PATH"); I was lazy here. I can a new variable if the reviewer kindly asks :) Comment on attachment 403766 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403766&action=review >> Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorUtils.cpp:49 >> + const char* path = g_getenv("WEBKIT_INJECTED_BUNDLE_PATH"); > > I was lazy here. I can a new variable if the reviewer kindly asks :) As this is going to be used only for developer builds, I think it is okay to reuse this variable that is already being set by all our scripts instead of introducing a new one which would need handling in many places. Committed r267159: <https://trac.webkit.org/changeset/267159> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403766 [details]. |