Summary: | [JSC] Intl.Collator should set usage:"search" option through ICU locale | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 213425 | ||||||||||||
Attachments: |
|
Description
Yusuke Suzuki
2020-07-01 19:09:03 PDT
Created attachment 403337 [details]
Patch
Comment on attachment 403337 [details]
Patch
I'll add more handling for privateuse.
Created attachment 403339 [details]
Patch
Comment on attachment 403339 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403339&action=review LGTM > JSTests/stress/intl-collator-co-extension.js:6 > +function shouldBeArray(actual, expected) { I should do this more often...I've used JSON.stringify too much in our Intl tests, haha. Comment on attachment 403339 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403339&action=review > Source/JavaScriptCore/runtime/IntlCollator.cpp:249 > + dataLocaleWithExtensions = dataLocale.utf8(); I need to make it `m_locale.utf8()` since "co" option in usage:"sort" is effective. Created attachment 403340 [details]
Patch for landing
Created attachment 403341 [details]
Patch for landing
ios and win failures are unrelated. Win failure is due to bad state of EWS (re-run of EWS is failing). ios thing is failing without this patch. https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fcanvas%2F2d.gradient.radial.cone.bottom.html Committed r263833: <https://trac.webkit.org/changeset/263833> |