Summary: | Overlapping content on earny.co | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aakash_jain, ap, bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, Hironori.Fujii, kondapallykalyan, pdr, simon.fraser, webkit-bot-watchers-bugzilla, zalan | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
zalan
2020-07-01 15:00:26 PDT
Created attachment 403327 [details]
Patch
Comment on attachment 403327 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403327&action=review > Source/WebCore/rendering/AutoTableLayout.cpp:75 > + columnLayout.minLogicalWidth = std::max(columnLayout.minLogicalWidth, 0.f); > + columnLayout.maxLogicalWidth = std::max(columnLayout.maxLogicalWidth, 0.f); I think we prefer std::max<float>() Created attachment 403371 [details]
Patch
Created attachment 403380 [details]
Patch
Committed r263855: <https://trac.webkit.org/changeset/263855> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403380 [details]. Various tests added in this commit are failing consistently on Windows. e.g.: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=fast%2Fcss%2Fpercentage-non-integer.html&test=fast%2Fcss%2Facid2-pixel.html&test=fast%2Fcss%2Facid2.html&test=tables%2Fmozilla%2Fbugs%2Fbug222336.html&platform=win&platform=wincairo Fujii did some test gardening for WinCairo in https://trac.webkit.org/r263884. We need similar test gardening for windows as well. |