Bug 213864

Summary:

Overlapping content on earny.co

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, bfulgham, changseok, esprehn+autocc, ews-watchlist, fujii.hironori, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bot-watchers-bugzilla, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

alan

Reported 2020-07-01 15:00:26 PDT

<rdar://problem/61011802>

Attachments
Patch (81.80 KB, patch) 2020-07-01 16:03 PDT, alan	no flags	Details Formatted Diff Diff
Patch (139.94 KB, patch) 2020-07-02 09:19 PDT, alan	no flags	Details Formatted Diff Diff
Patch (142.82 KB, patch) 2020-07-02 11:03 PDT, alan	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

alan

Comment 1 2020-07-01 16:03:53 PDT

Created attachment 403327 [details] Patch

Simon Fraser (smfr)

Comment 2 2020-07-01 21:22:43 PDT

Comment on attachment 403327 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403327&action=review > Source/WebCore/rendering/AutoTableLayout.cpp:75 > + columnLayout.minLogicalWidth = std::max(columnLayout.minLogicalWidth, 0.f); > + columnLayout.maxLogicalWidth = std::max(columnLayout.maxLogicalWidth, 0.f); I think we prefer std::max<float>()

alan

Comment 3 2020-07-02 09:19:32 PDT

Created attachment 403371 [details] Patch

alan

Comment 4 2020-07-02 11:03:56 PDT

Created attachment 403380 [details] Patch

EWS

Comment 5 2020-07-02 12:45:32 PDT

Committed r263855: <https://trac.webkit.org/changeset/263855> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403380 [details].

Aakash Jain

Comment 6 2020-07-04 06:31:30 PDT

Various tests added in this commit are failing consistently on Windows. e.g.: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=fast%2Fcss%2Fpercentage-non-integer.html&test=fast%2Fcss%2Facid2-pixel.html&test=fast%2Fcss%2Facid2.html&test=tables%2Fmozilla%2Fbugs%2Fbug222336.html&platform=win&platform=wincairo Fujii did some test gardening for WinCairo in https://trac.webkit.org/r263884. We need similar test gardening for windows as well.

Note You need to log in before you can comment on or make changes to this bug.