Bug 213804

Summary:

[ macOS wk2 ] REGRESSION(r263485): fast/scrolling/mac/scroll-snapping-in-progress.html is a flaky failure

Product:

WebKit

Reporter:

Jacob Uphoff <jacob_uphoff>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

ASSIGNED

Severity:

Normal

CC:

ap, hector_i_lopez, simon.fraser, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Jacob Uphoff

Reported 2020-06-30 11:36:30 PDT

fast/scrolling/mac/scroll-snapping-in-progress.html This test has been a flaky failure on macOS wk2 since it was introduced on r263485. History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fscrolling%2Fmac%2Fscroll-snapping-in-progress.html Diff: Sending wheel events PASS container.scrollTop > 0 is true -PASS window.internals.isScrollSnapInProgress(container) is true +FAIL window.internals.isScrollSnapInProgress(container) should be true. Was false. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE

Attachments
Patch (1.49 KB, patch) 2020-07-16 09:24 PDT, Hector Lopez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-06-30 11:36:59 PDT

<rdar://problem/64948258>

Simon Fraser (smfr)

Comment 2 2020-06-30 15:35:15 PDT

I can reproduce.

Simon Fraser (smfr)

Comment 3 2020-06-30 16:04:29 PDT

Doesn't reproduce when I turn on logging.

Simon Fraser (smfr)

Comment 4 2020-06-30 16:30:06 PDT

When it flakes, we send the scroll event earlier, so we haven't started the scroll snap timer in ScrollController yet.

Simon Fraser (smfr)

Comment 5 2020-06-30 16:32:45 PDT

Seem to relate to whether we handle the two wheel events in the same commit, or different commits.

Simon Fraser (smfr)

Comment 6 2020-06-30 16:49:33 PDT

I don't see a way to make a non-flakey version of this test with the APIs we have. I can't wait for scrolling completion, because scroll snap is something that delays completion. I can't control when scroll events fire relative to wheel events, and I can't use wheel handlers in the test because that sends us down the slow-scrolling path.

Hector Lopez

Comment 7 2020-07-16 09:24:22 PDT

Created attachment 404448 [details] Patch

Truitt Savell

Comment 8 2020-07-16 09:28:33 PDT

Comment on attachment 404448 [details] Patch Clearing flags on attachment: 404448 Committed r264460: <https://trac.webkit.org/changeset/264460>

Note You need to log in before you can comment on or make changes to this bug.