Bug 213722

Summary: [MSE][GStreamer] Rename MediaSourceGStreamer to MediaSourcePrivateGStreamer
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: WebKitGTKAssignee: Alicia Boya García <aboya>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bugs-noreply, calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, gyuyoung.kim, jer.noble, menard, philipj, pnormand, ryuan.choi, sergio, vjaquez
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alicia Boya García
Reported 2020-06-29 03:26:17 PDT
It's about time to remove this FIXME: // FIXME: Should this be called MediaSourcePrivateGStreamer? Yes, it should. Because it's a MediaSourcePrivate, and that is an important fact. The MSE class diagram is confusing enough already, let's fix this. To rebase commits after this change use `git format-patch` first to get them in a patch format and then run: sed -i 's|\<MediaSourceGStreamer\>|MediaSourcePrivateGStreamer|g' *.patch This patch is a refactor that produces no behavior changes.
Attachments
Patch (32.40 KB, patch)
2020-06-29 03:27 PDT, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2020-06-29 03:27:44 PDT
Created attachment 403047 [details] Patch
EWS
Comment 2 2020-06-29 04:50:24 PDT
Committed r263656: <https://trac.webkit.org/changeset/263656> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403047 [details].
Note You need to log in before you can comment on or make changes to this bug.