| Summary: | Support MediaRecorder.onstart | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cdumez, darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, jer.noble, kondapallykalyan, philipj, sergio, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Local Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 85851 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
youenn fablet
2020-06-29 02:59:18 PDT
Created attachment 403043 [details]
Patch
Created attachment 403052 [details]
Patch
Comment on attachment 403052 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403052&action=review > Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:129 > +ExceptionOr<void> MediaRecorder::startRecording(Optional<unsigned> timeSlice) It’s not really great to change the type here, but then store the value in m_timeSlice, an Optional<int>. Basically it’s the same incorrect conversion of large values to negative numbers, just done at a slightly later time. Comment on attachment 403052 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403052&action=review >> Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:129 >> +ExceptionOr<void> MediaRecorder::startRecording(Optional<unsigned> timeSlice) > > It’s not really great to change the type here, but then store the value in m_timeSlice, an Optional<int>. Basically it’s the same incorrect conversion of large values to negative numbers, just done at a slightly later time. This patch also updates m_timeSlice to be an Optional<unsigned>. Comment on attachment 403052 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403052&action=review >>> Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:129 >>> +ExceptionOr<void> MediaRecorder::startRecording(Optional<unsigned> timeSlice) >> >> It’s not really great to change the type here, but then store the value in m_timeSlice, an Optional<int>. Basically it’s the same incorrect conversion of large values to negative numbers, just done at a slightly later time. > > This patch also updates m_timeSlice to be an Optional<unsigned>. Oops, how did I overlook that? Committed r263671: <https://trac.webkit.org/changeset/263671> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403052 [details]. Reverted r263633, r263651, and r263671 for reason: Still seeing MediaRecorder test crashes after re-landing r263633 Committed r263854: <https://trac.webkit.org/changeset/263854> Created attachment 403455 [details]
Patch for relanding
(In reply to youenn fablet from comment #9) > Created attachment 403455 [details] > Patch for relanding Relanding, with the modification of enqueuing a task to dispatch error/start events given the startLoading callback can be called synchronously. ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Created attachment 403457 [details]
Patch for relanding
Committed r263896: <https://trac.webkit.org/changeset/263896> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403457 [details]. |