Bug 213694

Summary: [GTK] [Win] Build callOnMainThread on WTF::RunLoop rather than on a timer
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, bfulgham, cdumez, cgarcia, cmarcelo, ews-watchlist, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
cgarcia: review+, cgarcia: commit-queue-
Patch for landing
none
Patch for landing 2 none

Geoffrey Garen
Reported 2020-06-27 22:16:25 PDT
[GTK] [Win] Build callOnMainThread on WTF::RunLoop rather than on a timer
Attachments
Patch (4.69 KB, patch)
2020-06-27 22:17 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (4.86 KB, patch)
2020-06-27 22:21 PDT, Geoffrey Garen 		cgarcia: review+
cgarcia: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (5.70 KB, patch)
2020-06-29 20:52 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch for landing 2 (1.17 KB, patch)
2020-06-29 21:50 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2020-06-27 22:17:04 PDT
Created attachment 402986 [details] Patch
Geoffrey Garen
Comment 2 2020-06-27 22:21:16 PDT
Created attachment 402987 [details] Patch
Carlos Garcia Campos
Comment 3 2020-06-29 00:19:18 PDT
Comment on attachment 402987 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402987&action=review > Source/WTF/wtf/glib/RunLoopSourcePriority.h:-53 > - // callOnMainThread. > - MainThreadDispatcherTimer = 100, > - You should remove the WPE definition below too.
Geoffrey Garen
Comment 4 2020-06-29 20:52:56 PDT
Created attachment 403169 [details] Patch for landing
EWS
Comment 5 2020-06-29 21:25:55 PDT
Committed r263723: <https://trac.webkit.org/changeset/263723> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403169 [details].
Radar WebKit Bug Importer
Comment 6 2020-06-29 21:26:17 PDT
<rdar://problem/64922555>
Geoffrey Garen
Comment 7 2020-06-29 21:50:56 PDT
Reopening to attach new patch.
Geoffrey Garen
Comment 8 2020-06-29 21:50:57 PDT
Created attachment 403173 [details] Patch for landing 2
EWS
Comment 9 2020-06-29 22:33:41 PDT
Committed r263726: <https://trac.webkit.org/changeset/263726> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403173 [details].
Note You need to log in before you can comment on or make changes to this bug.