Summary: | [LFC][TFC] Adjust table content vertical position to match vertical-align | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
zalan
2020-06-27 21:37:43 PDT
Created attachment 402984 [details]
Patch
Comment on attachment 402984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402984&action=review > Source/WebCore/layout/displaytree/DisplayLineBox.h:64 > + void moveVertically(InlineLayoutUnit); Are you sure we want to make Display::LineBox mutable? (In reply to Antti Koivisto from comment #2) > Comment on attachment 402984 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402984&action=review > > > Source/WebCore/layout/displaytree/DisplayLineBox.h:64 > > + void moveVertically(InlineLayoutUnit); > > Are you sure we want to make Display::LineBox mutable? The other option is to regenerate them. Created attachment 403001 [details]
Patch
Committed r263640: <https://trac.webkit.org/changeset/263640> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403001 [details]. |