Bug 213692

Summary: [LFC][TFC] Adjust table content vertical position to match vertical-align
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2020-06-27 21:37:43 PDT
ssia
Attachments
Patch (9.02 KB, patch)
2020-06-27 21:43 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (9.12 KB, patch)
2020-06-28 10:09 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2020-06-27 21:43:24 PDT
Created attachment 402984 [details] Patch
Antti Koivisto
Comment 2 2020-06-28 03:59:41 PDT
Comment on attachment 402984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402984&action=review > Source/WebCore/layout/displaytree/DisplayLineBox.h:64 > + void moveVertically(InlineLayoutUnit); Are you sure we want to make Display::LineBox mutable?
alan
Comment 3 2020-06-28 07:06:20 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 402984 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402984&action=review > > > Source/WebCore/layout/displaytree/DisplayLineBox.h:64 > > + void moveVertically(InlineLayoutUnit); > > Are you sure we want to make Display::LineBox mutable? The other option is to regenerate them.
alan
Comment 4 2020-06-28 10:09:41 PDT
Created attachment 403001 [details] Patch
EWS
Comment 5 2020-06-28 17:03:28 PDT
Committed r263640: <https://trac.webkit.org/changeset/263640> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403001 [details].
Radar WebKit Bug Importer
Comment 6 2020-06-28 17:04:16 PDT
<rdar://problem/64869486>
Note You need to log in before you can comment on or make changes to this bug.