Bug 213692 - [LFC][TFC] Adjust table content vertical position to match vertical-align
Summary: [LFC][TFC] Adjust table content vertical position to match vertical-align
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-27 21:37 PDT by zalan
Modified: 2020-06-28 17:04 PDT (History)
5 users (show)

See Also:


Attachments
Patch (9.02 KB, patch)
2020-06-27 21:43 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (9.12 KB, patch)
2020-06-28 10:09 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-06-27 21:37:43 PDT
ssia
Comment 1 zalan 2020-06-27 21:43:24 PDT
Created attachment 402984 [details]
Patch
Comment 2 Antti Koivisto 2020-06-28 03:59:41 PDT
Comment on attachment 402984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402984&action=review

> Source/WebCore/layout/displaytree/DisplayLineBox.h:64
> +    void moveVertically(InlineLayoutUnit);

Are you sure we want to make Display::LineBox mutable?
Comment 3 zalan 2020-06-28 07:06:20 PDT
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 402984 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402984&action=review
> 
> > Source/WebCore/layout/displaytree/DisplayLineBox.h:64
> > +    void moveVertically(InlineLayoutUnit);
> 
> Are you sure we want to make Display::LineBox mutable?
The other option is to regenerate them.
Comment 4 zalan 2020-06-28 10:09:41 PDT
Created attachment 403001 [details]
Patch
Comment 5 EWS 2020-06-28 17:03:28 PDT
Committed r263640: <https://trac.webkit.org/changeset/263640>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403001 [details].
Comment 6 Radar WebKit Bug Importer 2020-06-28 17:04:16 PDT
<rdar://problem/64869486>