Bug 213637

Summary: Initializing the main thread should initialize the main run loop
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cdumez, cmarcelo, darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Geoffrey Garen
Reported 2020-06-25 21:16:31 PDT
Initializing the main thread should initialize the main run loop
Attachments
Patch (23.57 KB, patch)
2020-06-25 21:35 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (33.78 KB, patch)
2020-06-26 07:35 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (34.93 KB, patch)
2020-06-26 10:38 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2020-06-25 21:35:33 PDT
Created attachment 402849 [details] Patch
Geoffrey Garen
Comment 2 2020-06-26 07:35:03 PDT
Created attachment 402862 [details] Patch
Darin Adler
Comment 3 2020-06-26 09:33:15 PDT
Comment on attachment 402862 [details] Patch EWS failures *do* look like they are caused by the changes in the patch.
Geoffrey Garen
Comment 4 2020-06-26 09:52:38 PDT
Looks like I need to update WebKitTestRunner and DumpRenderTree. Oops!
Geoffrey Garen
Comment 5 2020-06-26 10:38:21 PDT
Created attachment 402880 [details] Patch
Saam Barati
Comment 6 2020-06-26 12:20:42 PDT
Comment on attachment 402880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402880&action=review > Source/WTF/ChangeLog:8 > + Previously, some code initialized one, some the other, and some both; what's "one" and "other" here?
Geoffrey Garen
Comment 7 2020-06-26 12:23:36 PDT
(In reply to Saam Barati from comment #6) > Comment on attachment 402880 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402880&action=review > > > Source/WTF/ChangeLog:8 > > + Previously, some code initialized one, some the other, and some both; > > what's "one" and "other" here? WTF::initializeMainThread() and WTF::RunLoop::initializeMain().
EWS
Comment 8 2020-06-26 12:28:22 PDT
Committed r263575: <https://trac.webkit.org/changeset/263575> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402880 [details].
Radar WebKit Bug Importer
Comment 9 2020-06-26 12:29:18 PDT
<rdar://problem/64817417>
Radar WebKit Bug Importer
Comment 10 2020-06-26 12:29:22 PDT
<rdar://problem/64817416>
Note You need to log in before you can comment on or make changes to this bug.