Summary: | Initializing the main thread should initialize the main run loop | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> | ||||||||
Component: | New Bugs | Assignee: | Geoffrey Garen <ggaren> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | andersca, benjamin, cdumez, cmarcelo, darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Geoffrey Garen
2020-06-25 21:16:31 PDT
Created attachment 402849 [details]
Patch
Created attachment 402862 [details]
Patch
Comment on attachment 402862 [details]
Patch
EWS failures *do* look like they are caused by the changes in the patch.
Looks like I need to update WebKitTestRunner and DumpRenderTree. Oops! Created attachment 402880 [details]
Patch
Comment on attachment 402880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402880&action=review > Source/WTF/ChangeLog:8 > + Previously, some code initialized one, some the other, and some both; what's "one" and "other" here? (In reply to Saam Barati from comment #6) > Comment on attachment 402880 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402880&action=review > > > Source/WTF/ChangeLog:8 > > + Previously, some code initialized one, some the other, and some both; > > what's "one" and "other" here? WTF::initializeMainThread() and WTF::RunLoop::initializeMain(). Committed r263575: <https://trac.webkit.org/changeset/263575> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402880 [details]. |