Bug 213637

Summary: Initializing the main thread should initialize the main run loop
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cdumez, cmarcelo, darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Geoffrey Garen 2020-06-25 21:16:31 PDT
Initializing the main thread should initialize the main run loop
Comment 1 Geoffrey Garen 2020-06-25 21:35:33 PDT
Created attachment 402849 [details]
Patch
Comment 2 Geoffrey Garen 2020-06-26 07:35:03 PDT
Created attachment 402862 [details]
Patch
Comment 3 Darin Adler 2020-06-26 09:33:15 PDT
Comment on attachment 402862 [details]
Patch

EWS failures *do* look like they are caused by the changes in the patch.
Comment 4 Geoffrey Garen 2020-06-26 09:52:38 PDT
Looks like I need to update WebKitTestRunner and DumpRenderTree. Oops!
Comment 5 Geoffrey Garen 2020-06-26 10:38:21 PDT
Created attachment 402880 [details]
Patch
Comment 6 Saam Barati 2020-06-26 12:20:42 PDT
Comment on attachment 402880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402880&action=review

> Source/WTF/ChangeLog:8
> +        Previously, some code initialized one, some the other, and some both;

what's "one" and "other" here?
Comment 7 Geoffrey Garen 2020-06-26 12:23:36 PDT
(In reply to Saam Barati from comment #6)
> Comment on attachment 402880 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402880&action=review
> 
> > Source/WTF/ChangeLog:8
> > +        Previously, some code initialized one, some the other, and some both;
> 
> what's "one" and "other" here?

WTF::initializeMainThread() and WTF::RunLoop::initializeMain().
Comment 8 EWS 2020-06-26 12:28:22 PDT
Committed r263575: <https://trac.webkit.org/changeset/263575>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402880 [details].
Comment 9 Radar WebKit Bug Importer 2020-06-26 12:29:18 PDT
<rdar://problem/64817417>
Comment 10 Radar WebKit Bug Importer 2020-06-26 12:29:22 PDT
<rdar://problem/64817416>