Bug 213637 – Initializing the main thread should initialize the main run loop

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Geoffrey Garen]

Initializing the main thread should initialize the main run loop

[Geoffrey Garen]

Created attachment 402849 [details]
Patch

[Geoffrey Garen]

Created attachment 402862 [details]
Patch

[Darin Adler]

Comment on attachment 402862 [details]
Patch

EWS failures *do* look like they are caused by the changes in the patch.

[Geoffrey Garen]

Looks like I need to update WebKitTestRunner and DumpRenderTree. Oops!

[Geoffrey Garen]

Created attachment 402880 [details]
Patch

[Saam Barati]

Comment on attachment 402880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402880&action=review

> Source/WTF/ChangeLog:8
> +        Previously, some code initialized one, some the other, and some both;

what's "one" and "other" here?

[Geoffrey Garen]

(In reply to Saam Barati from comment #6)
> Comment on attachment 402880 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402880&action=review
> 
> > Source/WTF/ChangeLog:8
> > +        Previously, some code initialized one, some the other, and some both;
> 
> what's "one" and "other" here?

WTF::initializeMainThread() and WTF::RunLoop::initializeMain().

[EWS]

Committed r263575: <https://trac.webkit.org/changeset/263575>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402880 [details].

[Radar WebKit Bug Importer]

<rdar://problem/64817417>

[Radar WebKit Bug Importer]

<rdar://problem/64817416>