| Summary: | Upstream date/time picker style | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||||
| Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | webkit-bug-importer, wenson_hsieh | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Megan Gardner
2020-06-25 17:22:32 PDT
Created attachment 402830 [details]
Patch
Comment on attachment 402830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402830&action=review > Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:102 > + return UIDatePickerStyleInline; This still needs to be guarded by HAVE(UIDATEPICKER_STYLE). Comment on attachment 402830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402830&action=review >> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:102 >> + return UIDatePickerStyleInline; > > This still needs to be guarded by HAVE(UIDATEPICKER_STYLE). It is at the call site, but I can add more guards if that seems prudent. (In reply to Megan Gardner from comment #3) > Comment on attachment 402830 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402830&action=review > > >> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:102 > >> + return UIDatePickerStyleInline; > > > > This still needs to be guarded by HAVE(UIDATEPICKER_STYLE). > > It is at the call site, but I can add more guards if that seems prudent. (To clarify — this needs to be guarded in order to fix the iOS 13.4 build) Created attachment 402840 [details]
Patch
Comment on attachment 402830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402830&action=review >>>> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:102 >>>> + return UIDatePickerStyleInline; >>> >>> This still needs to be guarded by HAVE(UIDATEPICKER_STYLE). >> >> It is at the call site, but I can add more guards if that seems prudent. > > (To clarify — this needs to be guarded in order to fix the iOS 13.4 build) yes... I see that now... Created attachment 402842 [details]
Patch for landing
Committed r263549: <https://trac.webkit.org/changeset/263549> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402842 [details]. |