Bug 213630

Summary: Upstream date/time picker style
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Megan Gardner
Reported 2020-06-25 17:22:32 PDT
Upstream date/time picker style
Attachments
Patch (1.96 KB, patch)
2020-06-25 17:27 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (1.91 KB, patch)
2020-06-25 18:25 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.90 KB, patch)
2020-06-25 19:25 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2020-06-25 17:27:30 PDT
Created attachment 402830 [details] Patch
Wenson Hsieh
Comment 2 2020-06-25 17:54:57 PDT
Comment on attachment 402830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402830&action=review > Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:102 > + return UIDatePickerStyleInline; This still needs to be guarded by HAVE(UIDATEPICKER_STYLE).
Megan Gardner
Comment 3 2020-06-25 18:23:03 PDT
Comment on attachment 402830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402830&action=review >> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:102 >> + return UIDatePickerStyleInline; > > This still needs to be guarded by HAVE(UIDATEPICKER_STYLE). It is at the call site, but I can add more guards if that seems prudent.
Wenson Hsieh
Comment 4 2020-06-25 18:25:50 PDT
(In reply to Megan Gardner from comment #3) > Comment on attachment 402830 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402830&action=review > > >> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:102 > >> + return UIDatePickerStyleInline; > > > > This still needs to be guarded by HAVE(UIDATEPICKER_STYLE). > > It is at the call site, but I can add more guards if that seems prudent. (To clarify — this needs to be guarded in order to fix the iOS 13.4 build)
Megan Gardner
Comment 5 2020-06-25 18:25:53 PDT
Created attachment 402840 [details] Patch
Megan Gardner
Comment 6 2020-06-25 18:28:25 PDT
Comment on attachment 402830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402830&action=review >>>> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:102 >>>> + return UIDatePickerStyleInline; >>> >>> This still needs to be guarded by HAVE(UIDATEPICKER_STYLE). >> >> It is at the call site, but I can add more guards if that seems prudent. > > (To clarify — this needs to be guarded in order to fix the iOS 13.4 build) yes... I see that now...
Megan Gardner
Comment 7 2020-06-25 19:25:34 PDT
Created attachment 402842 [details] Patch for landing
EWS
Comment 8 2020-06-25 19:47:20 PDT
Committed r263549: <https://trac.webkit.org/changeset/263549> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402842 [details].
Radar WebKit Bug Importer
Comment 9 2020-06-25 19:48:14 PDT
<rdar://problem/64787064>
Note You need to log in before you can comment on or make changes to this bug.