Bug 213615

Summary: generate-jsc-bundle should fail if passed an invalid remote-config-file parameter
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Tools / TestsAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, clopez, dpino, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=184699
Attachments:
Description Flags
Patch none

Description Carlos Alberto Lopez Perez 2020-06-25 13:33:00 PDT
We had an issue with one of the servers and we suffered a data loss, so the script for generating JSC bundles was not beeing able to find it's config file to upload the bundles to https://webkitgtk.org/jsc-built-products/x86_64/release/

You can see at: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/35062/steps/generate-jsc-bundle/logs/stdio how the script ends with zero status even when it can't find the config file that is passed via '--remote-config-file ../../remote-jsc-bundle-upload-config.json'

In this case it should fail, so the step becomes red and we can notice earlier.
Comment 1 Carlos Alberto Lopez Perez 2020-06-25 13:36:04 PDT
Created attachment 402804 [details]
Patch
Comment 2 EWS 2020-06-26 07:44:42 PDT
Committed r263557: <https://trac.webkit.org/changeset/263557>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402804 [details].
Comment 3 Radar WebKit Bug Importer 2020-06-26 07:45:18 PDT
<rdar://problem/64805410>