Bug 21357

Summary: DragImage should not depend on Frame and CachedImage
Product: WebKit Reporter: Sam Weinig <sam>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: REOPENED    
Severity: Normal CC: cgarcia, cmarcelo, darin, esprehn+autocc, gyuyoung.kim, mifenton, ojan.autocc, rakuco, roger_fong, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 21354    
Attachments:
Description Flags
Patch none

Sam Weinig
Reported 2008-10-03 22:08:06 PDT
It is a layering violation for DragImage to depend on Frame and CachedImage.
Attachments
Patch (14.83 KB, patch)
2013-04-07 04:58 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-04-07 04:58:34 PDT
Created attachment 196780 [details] Patch
WebKit Review Bot
Comment 2 2013-04-07 07:01:53 PDT
Attachment 196780 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/Clipboard.h', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/platform/DragImage.cpp', u'Source/WebCore/platform/DragImage.h', u'Source/WebCore/platform/blackberry/DragImageBlackBerry.cpp', u'Source/WebCore/platform/efl/DragImageEfl.cpp', u'Source/WebCore/platform/gtk/DragImageGtk.cpp', u'Source/WebCore/platform/mac/DragImageMac.mm', u'Source/WebCore/platform/qt/DragImageQt.cpp', u'Source/WebCore/platform/win/DragImageWin.cpp', u'Source/WebCore/platform/wx/DragImageWx.cpp']" exit_code: 1 Source/WebCore/dom/Clipboard.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 3 2013-04-08 06:34:00 PDT
Committed r147912: <http://trac.webkit.org/changeset/147912>
Roger Fong
Comment 4 2013-04-08 14:20:40 PDT
http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/47197/steps/compile-webkit/logs/stdio EWS bots are a bit unhappy right now sry :/
Carlos Garcia Campos
Comment 5 2013-04-08 23:29:46 PDT
(In reply to comment #4) > http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/47197/steps/compile-webkit/logs/stdio > > EWS bots are a bit unhappy right now sry :/ Ooops, I'm sorry, thanks for fixing it.
Carlos Garcia Campos
Comment 6 2014-09-17 03:06:55 PDT
hmm, it seems this layering violation was re-introduced in r159455, reopening.
Note You need to log in before you can comment on or make changes to this bug.