| Summary: | DragImage should not depend on Frame and CachedImage | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | REOPENED --- | ||||||
| Severity: | Normal | CC: | cgarcia, cmarcelo, darin, esprehn+autocc, gyuyoung.kim, mifenton, ojan.autocc, rakuco, roger_fong, rwlbuis, tonikitoo, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Mac | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 21354 | ||||||
| Attachments: |
|
||||||
|
Description
Sam Weinig
2008-10-03 22:08:06 PDT
Created attachment 196780 [details]
Patch
Attachment 196780 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/Clipboard.h', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/platform/DragImage.cpp', u'Source/WebCore/platform/DragImage.h', u'Source/WebCore/platform/blackberry/DragImageBlackBerry.cpp', u'Source/WebCore/platform/efl/DragImageEfl.cpp', u'Source/WebCore/platform/gtk/DragImageGtk.cpp', u'Source/WebCore/platform/mac/DragImageMac.mm', u'Source/WebCore/platform/qt/DragImageQt.cpp', u'Source/WebCore/platform/win/DragImageWin.cpp', u'Source/WebCore/platform/wx/DragImageWx.cpp']" exit_code: 1
Source/WebCore/dom/Clipboard.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r147912: <http://trac.webkit.org/changeset/147912> http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/47197/steps/compile-webkit/logs/stdio EWS bots are a bit unhappy right now sry :/ (In reply to comment #4) > http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/47197/steps/compile-webkit/logs/stdio > > EWS bots are a bit unhappy right now sry :/ Ooops, I'm sorry, thanks for fixing it. |