Bug 213531

Summary: Web Inspector: add a tooltip to the icon of overridden resources to clarify meaning
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
bburg: review+
Patch none

Devin Rousso
Reported 2020-06-23 14:02:42 PDT
The inverted icon is not immediately explanatory (although it is quickly identifiable), so we should add a `title` to provide it.
Attachments
Patch (22.54 KB, patch)
2020-06-23 14:06 PDT, Devin Rousso 		bburg: review+
DetailsFormatted DiffDiff
Patch (22.55 KB, patch)
2020-06-23 15:54 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-06-23 14:06:51 PDT
Created attachment 402589 [details] Patch
Blaze Burg
Comment 2 2020-06-23 15:43:52 PDT
Comment on attachment 402589 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402589&action=review r=me > Source/WebInspectorUI/ChangeLog:30 > + Add a `title` to the overriden resource icon that clarifies the fact that the resource was Nit: overridden > Source/WebInspectorUI/UserInterface/Views/DataGridNode.js:410 > + // Subclasses may override Nit: trailing period
Devin Rousso
Comment 3 2020-06-23 15:54:58 PDT
Created attachment 402601 [details] Patch
EWS
Comment 4 2020-06-23 16:21:43 PDT
Committed r263429: <https://trac.webkit.org/changeset/263429> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402601 [details].
Radar WebKit Bug Importer
Comment 5 2020-06-23 16:22:14 PDT
<rdar://problem/64669960>
Note You need to log in before you can comment on or make changes to this bug.