| Summary: | [iOS] Open element actions sometimes result in a hover instead of a click | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||
| Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin, dino, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Andy Estes
2020-06-23 14:02:15 PDT
Created attachment 402595 [details]
Patch
Comment on attachment 402595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402595&action=review > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:815 > + auto delegate = _delegate.getAutoreleased(); Why autoreleased? Autoreleased has unwanted performance cost. We need it when the result is being used as a non-smart-pointer return value, and not in any other cases I can think of. Let's use RetainPtr here, not autorelease. Just "auto delegate = _delegate.get()". This is analogous to what would be generated if we were using ARC, in fact. At some point, most calls to getAutoreleased elsewhere should also be replaced with calls to get, with some minor refactoring possibly needed to work with RetainPtr rather than a raw pointer. (In reply to Darin Adler from comment #3) > Comment on attachment 402595 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402595&action=review > > > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:815 > > + auto delegate = _delegate.getAutoreleased(); > > Let's use RetainPtr here, not autorelease. Will do. Created attachment 402675 [details]
Patch
Committed r263472: <https://trac.webkit.org/changeset/263472> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402675 [details]. |