Bug 213528

Summary: [WASM] [BigInt] Add I64 to BigInt conversion
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: chi187, dschuff, ews-watchlist, keith_miller, mark.lam, max, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Keith Miller
Reported 2020-06-23 13:00:01 PDT
Now that we have have a working BigInt implementation we should support the WASM <-> JS bindings for I64 to BigInt. See: https://github.com/WebAssembly/JS-BigInt-integration
Attachments
Patch (127.64 KB, patch)
2020-12-18 18:23 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (130.83 KB, patch)
2020-12-18 21:02 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (144.44 KB, patch)
2020-12-19 04:30 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (149.11 KB, patch)
2020-12-20 23:04 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (153.37 KB, patch)
2020-12-30 16:31 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (153.36 KB, patch)
2020-12-30 20:03 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-12-18 18:23:52 PST
Created attachment 416563 [details] Patch
Yusuke Suzuki
Comment 2 2020-12-18 21:02:12 PST
Created attachment 416566 [details] Patch
Yusuke Suzuki
Comment 3 2020-12-19 04:30:03 PST
Created attachment 416569 [details] Patch
Yusuke Suzuki
Comment 4 2020-12-20 23:04:53 PST
Created attachment 416595 [details] Patch
Yusuke Suzuki
Comment 5 2020-12-30 16:31:32 PST
Created attachment 416856 [details] Patch Rebaseline test expectation
Yusuke Suzuki
Comment 6 2020-12-30 20:03:24 PST
Created attachment 416859 [details] Patch
Michael Saboff
Comment 7 2021-01-05 10:59:22 PST
Comment on attachment 416859 [details] Patch LGTM r=me
Yusuke Suzuki
Comment 8 2021-01-05 11:52:11 PST
Comment on attachment 416859 [details] Patch Thanks! Landing.
EWS
Comment 9 2021-01-05 12:14:06 PST
Committed r271168: <https://trac.webkit.org/changeset/271168> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416859 [details].
Radar WebKit Bug Importer
Comment 10 2021-01-05 12:15:30 PST
<rdar://problem/72824086>
Yusuke Suzuki
Comment 11 2021-01-20 01:57:35 PST
*** Bug 220600 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.