Summary: | Make HTTP/3 experimental feature work on iOS and only create storage directory if enabled | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ggaren, guoye_zhang, sam, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Alex Christensen
2020-06-23 12:49:57 PDT
Created attachment 402583 [details]
Patch
Comment on attachment 402583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402583&action=review > Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:212 > +#if PLATFORM(MAC) > + NSString *format = @"Experimental%@"; > +#else > + NSString *format = @"WebKitExperimental%@"; > +#endif Is this correct for Catalyst? I don't know but it doesn't matter in this case. This is so users can use Safari's experimental features menu to turn on HTTP/3, and Safari is not a Catalyst app. WebKit currently has this: > configuration._allowsHTTP3 = parameters.http3Enabled; It’d be better if this is done instead: > if (parameters.http3Enabled) { > configuration._allowsHTTP3 = YES; > } Which won't override system level "enable HTTP/3 by default" Created attachment 402586 [details]
Patch
Seems like a great thing to add a regression test for. Created attachment 402600 [details]
Patch
Created attachment 402602 [details]
Patch
Comment on attachment 402602 [details]
Patch
r=me
Committed r263441: <https://trac.webkit.org/changeset/263441> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402602 [details]. |