Bug 213527

Summary:

Make HTTP/3 experimental feature work on iOS and only create storage directory if enabled

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ggaren, guoye_zhang, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Alex Christensen

Reported 2020-06-23 12:49:57 PDT

Make HTTP/3 experimental feature work on iOS and only create storage directory if enabled

Attachments
Patch (6.43 KB, patch) 2020-06-23 12:53 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (7.35 KB, patch) 2020-06-23 13:52 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (12.55 KB, patch) 2020-06-23 15:50 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (14.81 KB, patch) 2020-06-23 16:06 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2020-06-23 12:53:33 PDT

Created attachment 402583 [details] Patch

Sam Weinig

Comment 2 2020-06-23 13:25:28 PDT

Comment on attachment 402583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402583&action=review > Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:212 > +#if PLATFORM(MAC) > + NSString *format = @"Experimental%@"; > +#else > + NSString *format = @"WebKitExperimental%@"; > +#endif Is this correct for Catalyst?

Alex Christensen

Comment 3 2020-06-23 13:32:03 PDT

I don't know but it doesn't matter in this case. This is so users can use Safari's experimental features menu to turn on HTTP/3, and Safari is not a Catalyst app.

Guoye Zhang

Comment 4 2020-06-23 13:38:45 PDT

WebKit currently has this: > configuration._allowsHTTP3 = parameters.http3Enabled; It’d be better if this is done instead: > if (parameters.http3Enabled) { > configuration._allowsHTTP3 = YES; > } Which won't override system level "enable HTTP/3 by default"

Alex Christensen

Comment 5 2020-06-23 13:52:00 PDT

Created attachment 402586 [details] Patch

Geoffrey Garen

Comment 6 2020-06-23 14:13:49 PDT

Seems like a great thing to add a regression test for.

Alex Christensen

Comment 7 2020-06-23 15:50:37 PDT

Created attachment 402600 [details] Patch

Alex Christensen

Comment 8 2020-06-23 16:06:41 PDT

Created attachment 402602 [details] Patch