| Summary: | [JSC] Clobberize misses `write(Heap)` report in some nodes | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 213551 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Yusuke Suzuki
2020-06-23 11:44:46 PDT
Created attachment 402576 [details]
Patch
Comment on attachment 402576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402576&action=review r=me > Source/JavaScriptCore/ChangeLog:3 > + [JSC] Clobberize misses `write(World)` report in some nodes write(Heap). > Source/JavaScriptCore/ChangeLog:9 > + In some DFG nodes, clobberize phase misses `clobberTopFunctor` call while it is `write(World)`, You mean `write(Heap)`, right? Comment on attachment 402576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402576&action=review >> Source/JavaScriptCore/ChangeLog:3 >> + [JSC] Clobberize misses `write(World)` report in some nodes > > write(Heap). Right. >> Source/JavaScriptCore/ChangeLog:9 >> + In some DFG nodes, clobberize phase misses `clobberTopFunctor` call while it is `write(World)`, > > You mean `write(Heap)`, right? Right, fixed. Thanks! Created attachment 402577 [details]
Patch for landing
Created attachment 402579 [details]
Patch for landing
Committed r263445: <https://trac.webkit.org/changeset/263445> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402579 [details]. I'll use this bug shortly for webkitbot real test. Revert patch will be created, but it should be unrelated. Re-opened since this is blocked by bug 213551 OK, cool. Worked perfectly. |