Bug 213522

Summary: Drop AudioContextBase class
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: MediaAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: clark_wang, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, jer.noble, kangil.han, kondapallykalyan, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2020-06-23 10:19:27 PDT
Drop AudioContextBase class and have WebKitAudioContext subclass the new BaseAudioContext class instead. We recently introduced BaseAudioContext to match the specification and keeping AudioContextBase is now confusing.
Attachments
Patch (144.21 KB, patch)
2020-06-23 10:48 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-06-23 10:48:43 PDT
Created attachment 402568 [details] Patch
Geoffrey Garen
Comment 2 2020-06-23 10:56:41 PDT
Comment on attachment 402568 [details] Patch rs=me
EWS
Comment 3 2020-06-23 11:59:53 PDT
Committed r263410: <https://trac.webkit.org/changeset/263410> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402568 [details].
Radar WebKit Bug Importer
Comment 4 2020-06-23 12:00:19 PDT
<rdar://problem/64655624>
Note You need to log in before you can comment on or make changes to this bug.