Bug 213522 - Drop AudioContextBase class
Summary: Drop AudioContextBase class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency treegraph
 
Reported: 2020-06-23 10:19 PDT by Chris Dumez
Modified: 2020-06-23 12:00 PDT (History)
13 users (show)

See Also:


Attachments
Patch (144.21 KB, patch)
2020-06-23 10:48 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-06-23 10:19:27 PDT
Drop AudioContextBase class and have WebKitAudioContext subclass the new BaseAudioContext class instead.
We recently introduced BaseAudioContext to match the specification and keeping AudioContextBase is now confusing.
Comment 1 Chris Dumez 2020-06-23 10:48:43 PDT
Created attachment 402568 [details]
Patch
Comment 2 Geoffrey Garen 2020-06-23 10:56:41 PDT
Comment on attachment 402568 [details]
Patch

rs=me
Comment 3 EWS 2020-06-23 11:59:53 PDT
Committed r263410: <https://trac.webkit.org/changeset/263410>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402568 [details].
Comment 4 Radar WebKit Bug Importer 2020-06-23 12:00:19 PDT
<rdar://problem/64655624>