Bug 213518

Summary: [ews] Allow archiving 'jsc' product
Product: WebKit Reporter: Diego Pino <dpino>
Component: New BugsAssignee: Diego Pino <dpino>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, clopez, ews-watchlist, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Diego Pino
Reported 2020-06-23 08:03:05 PDT
[ews] Allow archiving 'jsc-only' product
Attachments
Patch (1.96 KB, patch)
2020-06-23 08:03 PDT, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (2.71 KB, patch)
2020-06-23 11:40 PDT, Diego Pino 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2020-06-23 08:03:37 PDT
Created attachment 402559 [details] Patch
Diego Pino
Comment 2 2020-06-23 08:04:59 PDT
It seems at this moment archiving 'jsc-only' products is not possible. See: https://ews-build.webkit.org/#/builders/38/builds/10 This patch attempts to allow archiving 'jsc-only' products.
Aakash Jain
Comment 3 2020-06-23 08:20:44 PDT
Comment on attachment 402559 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402559&action=review > Tools/BuildSlaveSupport/built-product-archive:235 > + elif platform == 'gtk' or platform == 'wpe' or platform == 'jsc-only': You can also simplify it to: elif platform in ('gtk', 'jsc-only', 'wpe'):
Aakash Jain
Comment 4 2020-06-23 09:06:38 PDT
Please add jsc-only to extractBuiltProduct as well.
Aakash Jain
Comment 5 2020-06-23 09:09:00 PDT
Maybe we should add support for 'jsc' as well, in case we decide to split up jsc ews queue (in builder and tester) as well.
Diego Pino
Comment 6 2020-06-23 11:40:34 PDT
Created attachment 402574 [details] Patch
Aakash Jain
Comment 7 2020-06-23 11:49:08 PDT
Comment on attachment 402574 [details] Patch I am not sure if both 'jsc' and 'jsc-only' should follow same code-path (as wpe/gtk), but that doesn't need to block this patch.
EWS
Comment 8 2020-06-23 12:51:58 PDT
Committed r263414: <https://trac.webkit.org/changeset/263414> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402574 [details].
Radar WebKit Bug Importer
Comment 9 2020-06-23 12:52:18 PDT
<rdar://problem/64658577>
Note You need to log in before you can comment on or make changes to this bug.