| Summary: | [WebXR] Fix PlatformXR initialization/destruction | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||
| Component: | New Bugs | Assignee: | Sergio Villar Senin <svillar> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cgarcia, dino, pnormand, svillar, webkit-bug-importer, youennf, zan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 208988 | ||||||
| Attachments: |
|
||||||
|
Description
Sergio Villar Senin
2020-06-23 04:50:25 PDT
Created attachment 402545 [details]
Patch
Comment on attachment 402545 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402545&action=review > Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:218 > s_instance->m_impl = makeUnique<Impl>(); Can we do this assignment in Instance constructor? And make m_impl a UniqueRef<> maybe? Comment on attachment 402545 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402545&action=review Thanks for the review! >> Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:218 >> s_instance->m_impl = makeUnique<Impl>(); > > Can we do this assignment in Instance constructor? > And make m_impl a UniqueRef<> maybe? Makes total sense. Committed r263447: <https://trac.webkit.org/changeset/263447> |