Bug 213500

Summary: [WebDriver][WPE] Allow running Selenium tests with the WPE WebDriver
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: WPE WebKitAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, ews-watchlist, glenn, jbedard
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 213916    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Lauro Moura
Reported 2020-06-22 20:20:29 PDT
The WPE WebDriver is available in the imported selenium from bug213263, but test infra needs to actually make them runnable with WPE.
Attachments
Patch (3.24 KB, patch)
2020-06-22 20:33 PDT, Lauro Moura 		no flags
DetailsFormatted DiffDiff
Patch (1.71 KB, patch)
2020-07-03 11:12 PDT, Lauro Moura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2020-06-22 20:33:21 PDT
Created attachment 402530 [details] Patch
Carlos Garcia Campos
Comment 2 2020-06-22 22:43:49 PDT
Comment on attachment 402530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402530&action=review > WebDriverTests/imported/selenium/py/conftest.py:48 > + 'WPEWebKit', I guess I forgot this on the selenium patch. Changes to this file should be done upstream, and then reimport. > WebDriverTests/imported/selenium/py/conftest.py:125 > + if driver_class == 'WPEWebKit': This is not correctly indented, no?
Lauro Moura
Comment 3 2020-07-02 20:48:26 PDT
(In reply to Carlos Garcia Campos from comment #2) > Comment on attachment 402530 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402530&action=review > > > WebDriverTests/imported/selenium/py/conftest.py:48 > > + 'WPEWebKit', > > I guess I forgot this on the selenium patch. Changes to this file should be > done upstream, and then reimport. Right. I've added a patch to bug213916 with the upstream version with this fix already merged. > > > WebDriverTests/imported/selenium/py/conftest.py:125 > > + if driver_class == 'WPEWebKit': > > This is not correctly indented, no? Indeed. Strange that the local version is correct. I'll update the patch.
Lauro Moura
Comment 4 2020-07-03 11:12:25 PDT
Created attachment 403469 [details] Patch
EWS
Comment 5 2020-07-04 09:04:54 PDT
Committed r263933: <https://trac.webkit.org/changeset/263933> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403469 [details].
Note You need to log in before you can comment on or make changes to this bug.