Bug 213263 - [WebDriver][WPE] Update imported selenium to a version with the WPE WebDriver
Summary: [WebDriver][WPE] Update imported selenium to a version with the WPE WebDriver
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-16 15:02 PDT by Lauro Moura
Modified: 2020-06-19 06:54 PDT (History)
3 users (show)

See Also:


Attachments
Patch (41.77 KB, patch)
2020-06-16 18:11 PDT, Lauro Moura
no flags Details | Formatted Diff | Diff
Patch (218.94 KB, patch)
2020-06-18 20:18 PDT, Lauro Moura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2020-06-16 15:02:44 PDT
The currently imported version of Selenium (300cd3fa0288d3a88eb4b4c459c54bd02a015118 - March 2018) does not have the WPE WebDriver module (merged in 0d7e57a7079c0a48286e8e741a0122916c08ca16 - Mar 2020).
Comment 1 Lauro Moura 2020-06-16 18:11:08 PDT
Created attachment 402062 [details]
Patch
Comment 2 Carlos Garcia Campos 2020-06-17 00:35:17 PDT
Comment on attachment 402062 [details]
Patch

Is this really including all the changes? I think the are more changes in tests and other files I don't see here
Comment 3 Lauro Moura 2020-06-18 20:16:07 PDT
(In reply to Carlos Garcia Campos from comment #2)
> Comment on attachment 402062 [details]
> Patch
> 
> Is this really including all the changes? I think the are more changes in
> tests and other files I don't see here

Indeed a bunch of changes were missing. I'm finishing some tests to update the patch. Thanks.
Comment 4 Lauro Moura 2020-06-18 20:18:35 PDT
Created attachment 402264 [details]
Patch
Comment 5 EWS 2020-06-19 06:53:05 PDT
Committed r263264: <https://trac.webkit.org/changeset/263264>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402264 [details].
Comment 6 Radar WebKit Bug Importer 2020-06-19 06:54:18 PDT
<rdar://problem/64530313>