Bug 21350

Summary:

WebCoreObjCExtras.c is actually an obj-c++ file

Product:

WebKit

Reporter:

Jeremy Moskovich <playmobil>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Rename platform/mac/WebCoreObjCExtras.c -> platform/mac/WebCoreObjCExtras.mm	none
it's->its	timothy: review+

Jeremy Moskovich

Reported 2008-10-03 15:16:49 PDT

The included wtf/MainThread.h and wtf/Threading.h both contain c++ namespace declarations.

Attachments
Rename platform/mac/WebCoreObjCExtras.c -> platform/mac/WebCoreObjCExtras.mm (13.33 KB, patch) 2008-10-03 15:18 PDT, Jeremy Moskovich	no flags	Details Formatted Diff Diff
it's->its (13.33 KB, patch) 2008-10-03 15:30 PDT, Jeremy Moskovich	timothy: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jeremy Moskovich

Comment 1 2008-10-03 15:18:44 PDT

Created attachment 24072 [details] Rename platform/mac/WebCoreObjCExtras.c -> platform/mac/WebCoreObjCExtras.mm Rename platform/mac/WebCoreObjCExtras.c -> platform/mac/WebCoreObjCExtras.mm

Dave Hyatt

Comment 2 2008-10-03 15:29:24 PDT

Comment on attachment 24072 [details] Rename platform/mac/WebCoreObjCExtras.c -> platform/mac/WebCoreObjCExtras.mm Typo in changelog: "it's" should be "its" r=me

Jeremy Moskovich

Comment 3 2008-10-03 15:30:58 PDT

Created attachment 24073 [details] it's->its

Eric Seidel (no email)

Comment 4 2008-10-06 18:10:40 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... R WebCore/platform/mac/WebCoreObjCExtras.c => WebCore/platform/mac/WebCoreObjCExtras.mm M WebCore/ChangeLog M WebCore/WebCore.xcodeproj/project.pbxproj Committed r37358

Note You need to log in before you can comment on or make changes to this bug.