Bug 213492

Summary: Web Inspector: Elements: Node: use a `WI.ContextMenu` instead of a `<select>` for listener filtering
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, inspector-bugzilla-changes, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2020-06-22 15:56:21 PDT
Using a `<select>` means that the context menu will appear in the same place no matter where the icon is clicked, but that is not needed, so just use a `WI.ContextMenu` instead (it's also simpler).
Attachments
Patch (6.54 KB, patch)
2020-06-22 15:57 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-06-22 15:57:42 PDT
Created attachment 402518 [details] Patch
EWS
Comment 2 2020-06-22 16:43:51 PDT
Committed r263376: <https://trac.webkit.org/changeset/263376> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402518 [details].
Radar WebKit Bug Importer
Comment 3 2020-06-22 16:44:16 PDT
<rdar://problem/64614336>
Nikita Vasilyev
Comment 4 2020-06-22 17:34:55 PDT
From the accessibility point, I think we should go the exact opposite way - use <select> elements instead of WI.ContextMenu on <div> elements whenever possible. In VoiceOver, when simulating a click by pressing Cmd-Shift-Ctrl-Option-Space, the context menu is shown as expected, but it isn't immediately focused. Also, with this patch, the filter icon is no longer tab-focusable.
Note You need to log in before you can comment on or make changes to this bug.