Bug 213472

Summary: Allow building JavaScriptCore Mac+arm64 in public SDK build
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, cdumez, cmarcelo, ews-watchlist, fpizlo, ggaren, gyuyoung.kim, jbedard, keith_miller, mark.lam, msaboff, rmorisset, ryuan.choi, sam, sergio, thorton, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
WIP
none
Patch none

Saam Barati
Reported 2020-06-22 11:54:42 PDT
...
Attachments
WIP (24.26 KB, patch)
2020-06-22 12:01 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
WIP (24.65 KB, patch)
2020-06-22 13:37 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Patch (30.50 KB, patch)
2020-06-22 15:17 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2020-06-22 12:01:41 PDT
Created attachment 402488 [details] WIP Let's test EWS. Current patch is a bit old, not even sure it'll apply to ToT still
Saam Barati
Comment 2 2020-06-22 13:37:36 PDT
Created attachment 402506 [details] WIP get it to compile take 2
Saam Barati
Comment 3 2020-06-22 15:17:07 PDT
Created attachment 402515 [details] Patch
Sam Weinig
Comment 4 2020-06-22 16:02:04 PDT
Comment on attachment 402515 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402515&action=review > Source/WTF/wtf/PlatformEnableCocoa.h:-163 > -/* FIXME: This should probably be HAVE_FAST_JIT_PERMISSIONS and may be entirely unnecessary due to runtime checking support via os_thread_self_restrict_rwx_is_supported(). */ > -#if !defined(ENABLE_FAST_JIT_PERMISSIONS) && CPU(ARM64) && !(OS(TVOS) || OS(WATCHOS)) && USE(APPLE_INTERNAL_SDK) Excited to see one of my fixme's being resolved!
Saam Barati
Comment 5 2020-06-22 16:22:43 PDT
(In reply to Sam Weinig from comment #4) > Comment on attachment 402515 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402515&action=review > > > Source/WTF/wtf/PlatformEnableCocoa.h:-163 > > -/* FIXME: This should probably be HAVE_FAST_JIT_PERMISSIONS and may be entirely unnecessary due to runtime checking support via os_thread_self_restrict_rwx_is_supported(). */ > > -#if !defined(ENABLE_FAST_JIT_PERMISSIONS) && CPU(ARM64) && !(OS(TVOS) || OS(WATCHOS)) && USE(APPLE_INTERNAL_SDK) > > Excited to see one of my fixme's being resolved! :-)
EWS
Comment 6 2020-06-22 18:28:22 PDT
Committed r263380: <https://trac.webkit.org/changeset/263380> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402515 [details].
Radar WebKit Bug Importer
Comment 7 2020-06-22 18:29:18 PDT
<rdar://problem/64618340>
Jonathan Bedard
Comment 8 2020-06-22 21:32:06 PDT
This broke the watchOS Simulator build: https://build.webkit.org/builders/Apple-watchOS-Simulator-6-Release-Build/builds/69
Saam Barati
Comment 9 2020-06-22 22:04:54 PDT
(In reply to Jonathan Bedard from comment #8) > This broke the watchOS Simulator build: > https://build.webkit.org/builders/Apple-watchOS-Simulator-6-Release-Build/ > builds/69 Will fix
Saam Barati
Comment 10 2020-06-22 22:28:49 PDT
attempted fix in: https://trac.webkit.org/changeset/263385/webkit
Jonathan Bedard
Comment 11 2020-06-23 07:43:27 PDT
(In reply to Saam Barati from comment #10) > attempted fix in: > https://trac.webkit.org/changeset/263385/webkit Thank you!
Saam Barati
Comment 12 2020-08-06 18:02:02 PDT
*** Bug 213102 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.