Bug 21347

Summary: FormDataStreamMac.mm calls isMainThread without #including <wtf/Threading.h>
Product: WebKit Reporter: Mark Mentovai <mark>
Component: PlatformAssignee: Mark Mentovai <mark>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, pinkerton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Adds the appropriate #import sam: review+

Mark Mentovai
Reported 2008-10-03 14:21:34 PDT
WebCore/platform/network/mac/FormDataStreamMac.mm calls isMainThread without the #include that declares that function. This causes a problem when building Chromium. FormDataStreamMac.mm does include <wtf/MainThread.h>, but that file does not bring in Threading.h or the isMainThread function.
Attachments
Adds the appropriate #import (910 bytes, patch)
2008-10-03 14:24 PDT, Mark Mentovai 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Mentovai
Comment 1 2008-10-03 14:24:02 PDT
Created attachment 24068 [details] Adds the appropriate #import
Darin Adler
Comment 2 2008-10-03 14:26:25 PDT
Comment on attachment 24068 [details] Adds the appropriate #import Why doesn't this break compilation? Is there something different about your configuration?
Mark Mentovai
Comment 3 2008-10-03 14:29:35 PDT
You might be getting it via prefix header injection, although we're using the same prefix header I assume you are, WebCore/WebCorePrefix.h.
Eric Seidel (no email)
Comment 4 2008-10-06 18:11:52 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/network/mac/FormDataStreamMac.mm Committed r37361
Note You need to log in before you can comment on or make changes to this bug.