Bug 21347

Summary: FormDataStreamMac.mm calls isMainThread without #including <wtf/Threading.h>
Product: WebKit Reporter: Mark Mentovai <mark>
Component: PlatformAssignee: Mark Mentovai <mark>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, pinkerton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Adds the appropriate #import sam: review+

Description Mark Mentovai 2008-10-03 14:21:34 PDT 
WebCore/platform/network/mac/FormDataStreamMac.mm calls isMainThread without the #include that declares that function.  This causes a problem when building Chromium.  FormDataStreamMac.mm does include <wtf/MainThread.h>, but that file does not bring in Threading.h or the isMainThread function.
Comment 1 Mark Mentovai 2008-10-03 14:24:02 PDT 
Created attachment 24068 [details]
Adds the appropriate #import
Comment 2 Darin Adler 2008-10-03 14:26:25 PDT 
Comment on attachment 24068 [details]
Adds the appropriate #import

Why doesn't this break compilation? Is there something different about your configuration?
Comment 3 Mark Mentovai 2008-10-03 14:29:35 PDT 
You might be getting it via prefix header injection, although we're using the same prefix header I assume you are, WebCore/WebCorePrefix.h.
Comment 4 Eric Seidel (no email) 2008-10-06 18:11:52 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/network/mac/FormDataStreamMac.mm
Committed r37361