Summary: | [WebXR] Introducing XRLayer | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||
Component: | New Bugs | Assignee: | Sergio Villar Senin <svillar> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | annulen, benjamin, calvaris, cdumez, cgarcia, darin, esprehn+autocc, ews-watchlist, gyuyoung.kim, kangil.han, koivisto, kondapallykalyan, ryuan.choi, sam, sergio, svillar, webkit-bug-importer, youennf | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 208988 | ||||||
Attachments: |
|
Description
Sergio Villar Senin
2020-06-22 07:38:54 PDT
Created attachment 402484 [details]
Patch
Comment on attachment 402484 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402484&action=review > Source/WebCore/Modules/webxr/WebXRLayer.h:48 > + WebXRLayer(ScriptExecutionContext*); explicit and ScriptExecutionContext& or is there a point in supporting nullptr? > Source/WebCore/Modules/webxr/WebXRLayer.h:51 > + ScriptExecutionContext* scriptExecutionContext() const override { return ContextDestructionObserver::scriptExecutionContext(); } final? > Source/WebCore/Modules/webxr/WebXRLayer.h:57 > + void derefEventTarget() override { deref(); } final for all of these? > Source/WebCore/Modules/webxr/WebXRSession.h:80 > + ScriptExecutionContext* scriptExecutionContext() const override { return ActiveDOMObject::scriptExecutionContext(); } final? > Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp:107 > WebXRWebGLLayer::WebXRWebGLLayer(WebXRSession& session, WebXRRenderingContext&& context, const XRWebGLLayerInit& init) Would be best to have a Ref<WebXRSession>&& > Source/WebCore/Modules/webxr/WebXRWebGLLayer.h:62 > + virtual ~WebXRWebGLLayer(); Not needed I believe Comment on attachment 402484 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402484&action=review Thanks for the review Youenn! >> Source/WebCore/Modules/webxr/WebXRLayer.h:48 >> + WebXRLayer(ScriptExecutionContext*); > > explicit and ScriptExecutionContext& or is there a point in supporting nullptr? OK >> Source/WebCore/Modules/webxr/WebXRLayer.h:57 >> + void derefEventTarget() override { deref(); } > > final for all of these? Ok >> Source/WebCore/Modules/webxr/WebXRSession.h:80 >> + ScriptExecutionContext* scriptExecutionContext() const override { return ActiveDOMObject::scriptExecutionContext(); } > > final? Ok >> Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp:107 >> WebXRWebGLLayer::WebXRWebGLLayer(WebXRSession& session, WebXRRenderingContext&& context, const XRWebGLLayerInit& init) > > Would be best to have a Ref<WebXRSession>&& Ok. >> Source/WebCore/Modules/webxr/WebXRWebGLLayer.h:62 >> + virtual ~WebXRWebGLLayer(); > > Not needed I believe Indeed. Committed r263403: <https://trac.webkit.org/changeset/263403> |