Bug 213450

Summary: [WTF] URL should support dataLog
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Yusuke Suzuki
Reported 2020-06-21 19:26:49 PDT
[WTF] URL should support dataLog
Attachments
Patch (3.37 KB, patch)
2020-06-21 19:29 PDT, Yusuke Suzuki
no flags
Patch (3.37 KB, patch)
2020-06-21 19:39 PDT, Yusuke Suzuki
no flags
Patch (3.37 KB, patch)
2020-06-21 19:47 PDT, Yusuke Suzuki
no flags
Yusuke Suzuki
Comment 1 2020-06-21 19:29:14 PDT
Yusuke Suzuki
Comment 2 2020-06-21 19:39:27 PDT
Yusuke Suzuki
Comment 3 2020-06-21 19:47:15 PDT
Yusuke Suzuki
Comment 4 2020-06-21 19:48:53 PDT
I need to admit that we should eventually merge TextStream (WebCore side thing) and PrintStream (WTF / JSC side thing) into one, but it requires a grand plan anyway :)
Mark Lam
Comment 5 2020-06-21 19:53:04 PDT
Comment on attachment 402441 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402441&action=review r=me with nit. > Source/WTF/wtf/URL.cpp:770 > +void URL::dump(PrintStream& out) const > +{ > + out.print(m_string); > +} nit: should we keep this definition in the header instead? If it's not normally used and we only need this for occasional debugging use, then it is more efficient to have it in the header vs explicitly putting it here. There a lot of other less commonly dumped data structures that do this also.
Yusuke Suzuki
Comment 6 2020-06-21 20:07:43 PDT
Comment on attachment 402441 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402441&action=review >> Source/WTF/wtf/URL.cpp:770 >> +} > > nit: should we keep this definition in the header instead? If it's not normally used and we only need this for occasional debugging use, then it is more efficient to have it in the header vs explicitly putting it here. There a lot of other less commonly dumped data structures that do this also. Discussed with Mark on Slack. We keep it as is to avoid including `#include <wtf/PrintStream.h>` in `URL.h`.
EWS
Comment 7 2020-06-21 23:50:24 PDT
Committed r263340: <https://trac.webkit.org/changeset/263340> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402441 [details].
Radar WebKit Bug Importer
Comment 8 2020-06-21 23:51:16 PDT
Note You need to log in before you can comment on or make changes to this bug.