Bug 213426

Summary: WebKit fails to leave audio routing arbitration during navigation, closing.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, peng.liu6, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing none

Description Jer Noble 2020-06-20 00:26:24 PDT 
WebKit fails to leave audio routing arbitration during navigation, closing.
Comment 1 Jer Noble 2020-06-20 00:27:37 PDT 
<rdar://problem/64395051>
Comment 2 Radar WebKit Bug Importer 2020-06-20 00:27:52 PDT 
<rdar://problem/64556258>
Comment 3 Jer Noble 2020-06-20 00:38:56 PDT 
Created attachment 402378 [details]
Patch
Comment 4 Jer Noble 2020-06-20 00:39:21 PDT 
<rdar://problem/64395051>
Comment 5 Eric Carlson 2020-06-20 14:41:13 PDT 
Comment on attachment 402378 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402378&action=review

Is it worth adding a test that deletes the <video> element?

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm:245
> +    case WebKit::AudioSessionRoutingArbitratorProxy::ArbitrationStatus::None:return WKWebViewAudioRoutingArbitrationStatusNone;

Nit: missing a space before "return"
Comment 6 Jer Noble 2020-06-20 18:02:50 PDT 
(In reply to Eric Carlson from comment #5)
> Comment on attachment 402378 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402378&action=review
> 
> Is it worth adding a test that deletes the <video> element?

Might as well!

> > Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm:245
> > +    case WebKit::AudioSessionRoutingArbitratorProxy::ArbitrationStatus::None:return WKWebViewAudioRoutingArbitrationStatusNone;
> 
> Nit: missing a space before "return"

Fixed.
Comment 7 Jer Noble 2020-06-20 18:06:59 PDT 
Created attachment 402412 [details]
Patch for landing
Comment 8 EWS 2020-06-21 08:34:18 PDT 
Committed r263328: <https://trac.webkit.org/changeset/263328>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402412 [details].
Comment 9 Antoine Quint 2020-06-22 00:19:05 PDT 
Committed r263342: <https://trac.webkit.org/changeset/263342>